Skip to content

Add changed lines counter #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

BernatBC
Copy link
Contributor

Added and removed lines are displayed on the commit details.
image

I also plan to add these stats to files. However, I'm not sure where to place them (2 and 3)?:

image

Another PR was created a while ago (#914), but I declined it.

@DarkDefender
Copy link

I'm not part of the development team, but I would prefer location 3.
This is because I think it will be too cluttered to have the changed lines in the file list view.

Of course it might be nice sometimes to see the number of lines that changed, but for that I think showing it in the diff view (location 3) is good enough.

That's how they do it here on github as well (display it in the same place as the file name in the diff view):
image

@BernatBC
Copy link
Contributor Author

I updated the PR to include the number of lines changed on files:
Screenshot From 2025-04-13 17-13-55

@love-linger
Copy link
Collaborator

I agree with @DarkDefender. For me, the count of changed lines is useless.

And in the INFORMATION view, the STAT part is easy to cause misunderstanding. I think most people will more easily understand it as "Added X file(s), Modified Y file(s), Deleted Z files"

@love-linger love-linger self-assigned this Apr 17, 2025
@love-linger love-linger added the not-planned It's not planned in the future label Apr 17, 2025
@love-linger love-linger force-pushed the develop branch 4 times, most recently from ed356cd to 2a43efd Compare April 17, 2025 07:43
@BernatBC BernatBC closed this Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-planned It's not planned in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants